fix: page.pause() timeout reset #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Nov 13, 2023
| @@ -248,15 +248,18 @@ def set_default_navigation_timeout(self, timeout: float) -> None: | |||
| def _set_default_navigation_timeout_impl(self, timeout: Optional[float]) -> None: | |||
| self._timeout_settings.set_default_navigation_timeout(timeout) | |||
| self._channel.send_no_reply( | |||
| "setDefaultNavigationTimeoutNoReply", dict(timeout=timeout) | |||
| "setDefaultNavigationTimeoutNoReply", | |||
| {} if timeout is None else {"timeout": timeout}, | |||
There was a problem hiding this comment.
The issue was that on protocol level we don't allow timeout to be null.
There was a problem hiding this comment.
Should we consider serializing None as undefined or too many things break?
There was a problem hiding this comment.
too many things would break I believe!
mxschmitt
force-pushed
the
fix-page-pause-timeout-reset
branch
from
432dbeb to
d1bd87c
Compare
yury-s
approved these changes
Nov 13, 2023
|
|
||
| await page.goto(server.EMPTY_PAGE) | ||
| page.pause() | ||
| with pytest.raises(Error, match="Timeout 30000ms exceeded."): |
There was a problem hiding this comment.
Do we really want to slow down all tests by 30s?
There was a problem hiding this comment.
I think no other option instead of hacking around the impl for testing.
| @@ -248,15 +248,18 @@ def set_default_navigation_timeout(self, timeout: float) -> None: | |||
| def _set_default_navigation_timeout_impl(self, timeout: Optional[float]) -> None: | |||
| self._timeout_settings.set_default_navigation_timeout(timeout) | |||
| self._channel.send_no_reply( | |||
| "setDefaultNavigationTimeoutNoReply", dict(timeout=timeout) | |||
| "setDefaultNavigationTimeoutNoReply", | |||
| {} if timeout is None else {"timeout": timeout}, | |||
There was a problem hiding this comment.
Should we consider serializing None as undefined or too many things break?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2154