Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(roll): roll Playwright to 1.40.0-alpha-oct-18-2023 #2167

Merged
merged 1 commit into from
Nov 16, 2023
Merged

chore(roll): roll Playwright to 1.40.0-alpha-oct-18-2023 #2167

merged 1 commit into from
Nov 16, 2023

Conversation

mxschmitt
Copy link
Member

yury-s
yury-s approved these changes Nov 16, 2023
View reviewed changes
playwright/_impl/_waiter.py


class WaitHelper:
class Waiter:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the old name better, it is less ambiguous as it has less to do with restaurants business.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but keep the ports aligned! :/

@mxschmitt mxschmitt merged commit 9271ab9 into main Nov 16, 2023
38 of 40 checks passed
@mxschmitt mxschmitt deleted the roll/batch-1 branch November 16, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @yury-s