chore(roll): roll Playwright to 1.40.0 #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Nov 21, 2023
| await self._channel.send( | ||
| "setInputFiles", | ||
| { | ||
| **filter_none( |
There was a problem hiding this comment.
I might follow up and do it like in .NET that we remove None by default in send().
mxschmitt
force-pushed
the
roll/v1.40.0
branch
from
8047115 to
179749c
Compare
yury-s
approved these changes
Nov 21, 2023
| { | ||
| "name": item["name"], | ||
| "mimeType": item["mimeType"], | ||
| "buffer": base64.b64encode(item["buffer"]).decode(), |
There was a problem hiding this comment.
why is it encode than decode, is it just the python way to do base64 encoding?
There was a problem hiding this comment.
b64encode returns bytes which we need to decode to a str.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2078