chore: use Sequence for input List like types #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
Sequence-types
branch
2 times, most recently
from
46d8346 to
eaa5705
Compare
mxschmitt
force-pushed
the
Sequence-types
branch
from
eaa5705 to
1a209ba
Compare
dgozman
reviewed
Nov 29, 2023
scripts/documentation_provider.py
Outdated
| @@ -421,7 +424,7 @@ def inner_serialize_doc_type(self, type: Any, direction: str) -> str: | |||
| if "templates" in type: | |||
| base = type_name | |||
| if type_name == "Array": | |||
| base = "List" | |||
| base = "Sequence" | |||
There was a problem hiding this comment.
Let's make sure this is only applied to input parameters, not output values.
mxschmitt
force-pushed
the
Sequence-types
branch
from
1a209ba to
7046f29
Compare
dgozman
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1954
Fixes #1953
Relates #2174