chore: refactor TestServer/Request class #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Nov 30, 2023
| @@ -528,7 +527,7 @@ async def screenshot( | |||
| params = locals_to_params(locals()) | |||
| return await self._with_element( | |||
| lambda h, timeout: h.screenshot( | |||
| **ChainMap({"timeout": timeout}, params), | |||
There was a problem hiding this comment.
This reverts #1877 which seems not relevant anymore since our linters are happy.
mxschmitt
commented
Nov 30, 2023
| @@ -49,7 +49,7 @@ async def test_should_roundtrip_cookie( | |||
| cookies = await context.cookies() | |||
| await context.clear_cookies() | |||
| assert await context.cookies() == [] | |||
| await context.add_cookies(cookies) | |||
There was a problem hiding this comment.
mxschmitt
force-pushed
the
get-rid-of-HttpRequestWithPostBody
branch
from
24c74b2 to
d026d64
Compare
mxschmitt
force-pushed
the
get-rid-of-HttpRequestWithPostBody
branch
from
d026d64 to
eb70437
Compare
dgozman
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2174