Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mask_color for screenshots #2205

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix: mask_color for screenshots #2205

merged 2 commits into from
Jan 3, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Dec 21, 2023

Fixes #2204

The problem was that we were sending the params with the wrong keys over the protocol.

Expected: camelCase
Actual: snake case

So the server side / dispatcher side didn't receive any value.

@mxschmitt mxschmitt merged commit d943ab8 into main Jan 3, 2024
38 checks passed
@mxschmitt mxschmitt deleted the fix-mask-color branch January 3, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Page.screenshot() the param mask_color is invalid,always pink
2 participants