Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osx-arm64 and linux-aarch64 conda package builds #2211

Merged
merged 10 commits into from
Apr 2, 2024

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Dec 26, 2023

Adds cross-compile builds for conda packages, so that playwright-python can be installed on Apple Silicon (osx-arm64) and ARM (linux-aarch64).

Fixes #1745

@Tobias-Fischer
Copy link
Contributor Author

This is ready for review @mxschmitt

@Tobias-Fischer
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Queensland University of Technology"

@mxschmitt
Copy link
Member

Hello, thanks for your contribution! I tried to execute this locally on my linux machine, but getting an error that the argument is not available:

conda build: error: unrecognized arguments: --target-platform=linux-aarch64

I also did not find documentation for this command either. What do I do differently?

@Tobias-Fischer
Copy link
Contributor Author

Hi @mxschmitt - you are completely right, this syntax does not work for conda build. I am used to using https://github.com/mamba-org/boa where this is an option. I fixed up the PR - it would be great if you could have another look.

@manglav
Copy link

manglav commented Feb 21, 2024

ping on this?

@cdeil
Copy link

cdeil commented Mar 31, 2024

@mxschmitt - any chance to merge this in?

Would be super to have conda packages on Mac. :-)

@Tobias-Fischer
Copy link
Contributor Author

Check https://anaconda.org/tobiasrobotics/playwright if you need it

@mxschmitt mxschmitt merged commit 66ddfee into microsoft:main Apr 2, 2024
2 checks passed
@Tobias-Fischer Tobias-Fischer deleted the patch-1 branch April 2, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't install Playwright with Conda on M1 Mac
4 participants