Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(roll): roll to Playwright 1.41.0-beta-1705101589000 #2225

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jan 5, 2024

Fixes #2176

@mxschmitt mxschmitt force-pushed the roll/1.41.0-alpha-1702670966000-part-1 branch from e057914 to ac3211e Compare January 5, 2024 14:26
@mxschmitt mxschmitt force-pushed the roll/1.41.0-alpha-1702670966000-part-1 branch from 040dc89 to a2ec2bd Compare January 12, 2024 22:25
@mxschmitt mxschmitt force-pushed the roll/1.41.0-alpha-1702670966000-part-1 branch from a044c0d to 9df606f Compare January 12, 2024 23:04
@mxschmitt mxschmitt changed the title chore(roll): roll to Playwright 1.41.0-alpha-1702670966000 part 1 chore(roll): roll to Playwright 1.41.0-beta-1705101589000 Jan 15, 2024
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look into most of the tests since a bunch of them just moved around.

from tests.utils import must


def test_context_unroute_all_removes_all_handlers(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other tests for async version of unrouteAll?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are in tests/async/test_unroute_behavior.py.

@mxschmitt mxschmitt merged commit 6e586ed into main Jan 16, 2024
36 of 40 checks passed
@mxschmitt mxschmitt deleted the roll/1.41.0-alpha-1702670966000-part-1 branch January 16, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ports]: Backport client side changes
2 participants