fix: Update to greenlet 3.0.3 #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package `greenlet` version 3.0.1 breaks Apache Superset. Thus, it is not possible to install both Playwright and Apache Superset into the same virtualenv.
3 tasks
|
@microsoft-github-policy-service agree |
mxschmitt
approved these changes
Jan 7, 2024
|
Dear Max, thank you for the quick approval. Do you think the failures at Build (macos-latest, 3.8, firefox) are related to this change, or are they merely just flukes? With kind regards, |
|
These are unrelated errors, restarted one job, and will merge tomorrow. Danke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear lovely maintainers of Playwright,
first of all, a happy new year 🍀, and thank you so much for conceiving and maintaining this excellent piece of software.
Coming from crate/cratedb-examples#217 (review), we discovered that the
greenletpackage in version 3.0.1 breaks Apache Superset, tripping a segmentation fault. Thus, it is not possible to install both Playwright and Apache Superset into the same virtualenv without further ado.This patch fixes the problem by upgrading to greenlet version 3.0.3.
With kind regards,
Andreas.