-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch bug in locals_to_params #2300
Conversation
Calls to locals_to_params now handles nested params properly issue: 1269
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danphenderson please sync your branch with base branch.
Looks like generally speaking we can do something like that but we need to skip the logic for Edit: Seems like we don't need to skip it, since we serialise it differently: playwright-python/playwright/_impl/_fetch.py Line 373 in 04b7851
Would it be possible to add a test for it? |
I updated my branch. Sorry for the delay. Regarding tests, can you provide me with more precise instructions on where you would like them to live? |
|
Thanks, the test coverage has been added - please let me know if any additional changes are needed. |
Calls to
locals_to_params
now handle nested params properly.See comment in issue: 1269