Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch bug in locals_to_params #2300

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

danphenderson
Copy link
Contributor

Calls to locals_to_params now handle nested params properly.

See comment in issue: 1269

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danphenderson please sync your branch with base branch.

@mxschmitt
Copy link
Member

mxschmitt commented Sep 2, 2024

Looks like generally speaking we can do something like that but we need to skip the logic for json_data like we do in .NET: https://github.com/search?q=repo%3Amicrosoft%2Fplaywright-dotnet+DefaultJsonSerializerOptionsKeepNulls&type=code

Edit: Seems like we don't need to skip it, since we serialise it differently:

json_data = json.dumps(data)

Would it be possible to add a test for it?

@danphenderson
Copy link
Contributor Author

I updated my branch. Sorry for the delay.

Regarding tests, can you provide me with more precise instructions on where you would like them to live?

@mxschmitt
Copy link
Member

@danphenderson
Copy link
Contributor Author

Thanks, the test coverage has been added - please let me know if any additional changes are needed.

@mxschmitt mxschmitt merged commit bc88ac9 into microsoft:main Sep 6, 2024
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants