Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix incorrect type hints + refactor for impoved consistency #2304

Closed
wants to merge 10 commits into from
Closed

[WIP] fix incorrect type hints + refactor for impoved consistency #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
42afbd7
fix(wip): incorrect type hints for optional params/attributes
Feb 16, 2024
4af9951
chore(wip): update Union[Type, None] to Optional[Type]
Feb 16, 2024
dcc5d7e
chore: accessing typing module consistently
Feb 16, 2024
728d3ea
fix(wip): incorrect optional type hints
Feb 16, 2024
09f138e
fix(wip): incorrect optional type hints
Feb 16, 2024
b642750
fix(wip): incorrect optional type hints
Feb 16, 2024
f790c80
fix: incorrect type hints
Feb 16, 2024
99dcd81
chore: consistent decleration of optional params
Feb 16, 2024
52bc2fa
fix: incorrect optional type hints
Feb 16, 2024
db25da2
Merge branch 'main' into 2303-fix-type-hints
Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion playwright/_impl/_accessibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ def __init__(self, channel: Channel) -> None:
self._dispatcher_fiber = channel._connection._dispatcher_fiber

async def snapshot(
self, interestingOnly: bool = None, root: ElementHandle = None
self,
interestingOnly: Optional[bool] = None,
root: Optional[ElementHandle] = None,
) -> Optional[Dict]:
params = locals_to_params(locals())
if root:
Expand Down
Loading