Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser_context.route for service worker requests #2345

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Fix browser_context.route for service worker requests #2345

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afedd89
Fix route from service worker
LironHaroni Mar 7, 2024
7c9984b
remove test
LironHaroni Mar 7, 2024
c5ad3be
remove space
LironHaroni Mar 7, 2024
6b6afe7
...
LironHaroni Mar 7, 2024
76db854
Fix comment
LironHaroni Mar 7, 2024
ac2db12
Merge branch 'main' into fix_route_from_service_worker
LironHaroni Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion playwright/_impl/_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,10 @@ def _target_closed_future(self) -> asyncio.Future:
return page._closed_or_crashed_future

def _safe_page(self) -> "Optional[Page]":
return cast("Frame", from_channel(self._initializer["frame"]))._page
frame = from_nullable_channel(self._initializer.get("frame"))
if not frame:
return None
return cast("Frame", frame)._page


class Route(ChannelOwner):
Expand Down
Loading