Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Python 3.8 #2627

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ extends:
steps:
- task: UsePythonVersion@0
inputs:
versionSpec: '3.8'
versionSpec: '3.9'
displayName: 'Use Python'
- script: |
python -m pip install --upgrade pip
Expand Down
11 changes: 1 addition & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,9 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.8', '3.9']
python-version: ['3.9', '3.10']
browser: [chromium, firefox, webkit]
include:
- os: ubuntu-latest
python-version: '3.10'
browser: chromium
- os: windows-latest
python-version: '3.10'
browser: chromium
- os: macos-latest
python-version: '3.10'
browser: chromium
- os: windows-latest
python-version: '3.11'
browser: chromium
Expand Down
6 changes: 3 additions & 3 deletions meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ build:

requirements:
build:
- python >=3.8 # [build_platform != target_platform]
- python >=3.9 # [build_platform != target_platform]
- pip # [build_platform != target_platform]
- cross-python_{{ target_platform }} # [build_platform != target_platform]
host:
- python >=3.8
- python >=3.9
- wheel
- pip
- curl
- setuptools_scm
run:
- python >=3.8
- python >=3.9
- greenlet ==3.1.1
- pyee ==12.0.0

Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ asyncio_mode = "auto"

[tool.mypy]
ignore_missing_imports = true
python_version = "3.8"
python_version = "3.9"
warn_unused_ignores = false
warn_redundant_casts = true
warn_unused_configs = true
Expand All @@ -36,7 +36,7 @@ profile = "black"
[tool.pyright]
include = ["playwright", "tests", "scripts"]
exclude = ["**/node_modules", "**/__pycache__", "**/.*", "./build"]
pythonVersion = "3.8"
pythonVersion = "3.9"
reportMissingImports = false
reportTypedDictNotRequiredAccess = false
reportCallInDefaultInitializer = true
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ def _download_and_extract_local_driver(
"Topic :: Internet :: WWW/HTTP :: Browsers",
"Intended Audience :: Developers",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -237,7 +236,7 @@ def _download_and_extract_local_driver(
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
],
python_requires=">=3.8",
python_requires=">=3.9",
cmdclass={"bdist_wheel": PlaywrightBDistWheelCommand},
entry_points={
"console_scripts": [
Expand Down
Loading