chore: convert setup.py to build #2642
Conversation
mxschmitt
force-pushed
the
convert-to-build
branch
4 times, most recently
from
12de833 to
8a652e7
Compare
mxschmitt
force-pushed
the
convert-to-build
branch
from
8a652e7 to
d13e7c2
Compare
| @@ -60,132 +108,78 @@ def download_driver(zip_name: str) -> None: | |||
|
|
|||
|
|
|||
| class PlaywrightBDistWheelCommand(BDistWheelCommand): | |||
| user_options = BDistWheelCommand.user_options + [ | |||
There was a problem hiding this comment.
Env var seems simpler, since option passing via build is not fully working anyways: pypa/setuptools#2491. Changed it from --all to explicitly passing the output wheel name.
| print(bundle["wheel"]) | ||
| exit(0) | ||
|
|
||
| from setuptools import setup # noqa: E402 |
There was a problem hiding this comment.
The order here is non-common because we have the dependencies available only in non-build environments since I removed the deps from local-requirements.txt.
| @@ -683,7 +683,7 @@ def fulfill( | |||
| json: typing.Optional[typing.Any] = None, | |||
| path: typing.Optional[typing.Union[str, pathlib.Path]] = None, | |||
| content_type: typing.Optional[str] = None, | |||
| response: typing.Optional["APIResponse"] = None | |||
There was a problem hiding this comment.
I'll extract them into a separate PR tomorrow.
There was a problem hiding this comment.
Its hard to split the changes, since black starts reading [project.requires-python] from the pyproject.toml. Lets land together.
|
|
||
| wheels = base_wheel_bundles | ||
| if not self.all: | ||
| # Limit to 1, since for MacOS e.g. we have multiple wheels for the same platform and architecture and Conda expects 1. |
There was a problem hiding this comment.
is this comment still relevant? if so restore?
There was a problem hiding this comment.
Not anymore since we always output a single wheel now instead of multiple like before.
Similar to microsoft/playwright-pytest#254 - a little bit more complex here, because we previously were generating multiple wheels out of a single
setup.pyinvocation. This is not supported with their new build infrastructure. To workaround this, I manage the loop from the outside which seems to work as well.This addresses #2124 (comment).