fix: don't rely on requestAnimationFrame (#34065)

microsoft · Dec 18, 2024 · 443b2a2 · 443b2a2
1 parent c9ae644
commit 443b2a2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/html-reporter/src/links.tsx b/packages/html-reporter/src/links.tsx
@@ -143,7 +143,7 @@ export function useIsAnchored(id: AnchorID) {
 export function Anchor({ id, children }: React.PropsWithChildren<{ id: AnchorID }>) {
   const ref = React.useRef<HTMLDivElement>(null);
   const onAnchorReveal = React.useCallback(() => {
-    requestAnimationFrame(() => ref.current?.scrollIntoView({ block: 'start', inline: 'start' }));
+    ref.current?.scrollIntoView({ block: 'start', inline: 'start' });
   }, []);
   useAnchor(id, onAnchorReveal);
 

diff --git a/tests/playwright-test/reporter-html.spec.ts b/tests/playwright-test/reporter-html.spec.ts
@@ -936,6 +936,9 @@ for (const useIntermediateMergeReport of [true, false] as const) {
       await expect(attachment).not.toBeInViewport();
       await page.getByLabel('attach "foo-2"').getByTitle('link to attachment').click();
       await expect(attachment).toBeInViewport();
+
+      await page.reload();
+      await expect(attachment).toBeInViewport();
     });
 
     test('should highlight textual diff', async ({ runInlineTest, showReport, page }) => {