devops: speculative fix for flakiness dashboard data loss #32963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Oct 4, 2024
Test results for "tests 1"35761 passed, 680 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes loose data, e.g. between edge-beta bots (3 platforms) only 1 platforms appears on the dashboard. For some runs others appear.
Our speculation is that there is a race here:
playwright/utils/flakiness-dashboard/processing/dashboard_raw.js
Line 21 in 80ff7c3
Lets see if thats the case and limit it to 1 which should be enough for our scale.
See here, that its by default 8 * the number of CPUs.