Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(test): do not allow mixing tests from different types (#29284)" #33002

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Oct 8, 2024

This reverts commit 4784139.

Closes #29734.

Reason for revert: this original change only covers cases where test.describe() is explicitly called in a file. However, most users have top-level definition of tests without a describe block, so it does not solve both problems it was introduced for:

  • mixing hooks and tests, e.g. test1.beforeEach() and test2();
  • mixing test1.use() and test2();
  • forcing different workers inside a single file/suite because of different worker fixtures between test1() and test2().

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Test results for "tests 1"

35856 passed, 619 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit d0f2170 into microsoft:main Oct 8, 2024
29 checks passed
@mxschmitt mxschmitt deleted the revert-4784139bb0bce071c0745c6c07f623c37d3c70ce branch October 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression]: Can't call test.use() inside a describe() suite of a different test
2 participants