Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add time information to Call and Network tabs in Trace Viewer #33935

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Dec 10, 2024

Adds startTime display to the Call tab.

image

Adds various time metric display to the Network tab expanded view.

image

Minor code cleanup to make it more Reacty.

This comment has been minimized.

This comment has been minimized.

@agg23
Copy link
Contributor Author

agg23 commented Dec 11, 2024

Tagging #33823

packages/trace-viewer/src/ui/workbench.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/callTab.tsx Outdated Show resolved Hide resolved
@agg23 agg23 requested a review from yury-s December 18, 2024 20:49

This comment has been minimized.

@pavelfeldman
Copy link
Member

What is Start time?

@agg23 agg23 requested a review from pavelfeldman December 19, 2024 20:41

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-cdn.spec.ts:41:7 › playwright cdn failover should work (https://cdn.playwright.dev) @package-installations-ubuntu-latest
⚠️ [webkit-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37392 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 merged commit 05472f5 into microsoft:main Dec 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants