Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add url option to routeFromHAR call if codegen launched with --save-har-glob #34048

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ruifigueira
Copy link
Contributor

Fixes: #34020

@ruifigueira
Copy link
Contributor Author

ruifigueira commented Dec 17, 2024

@pavelfeldman I was trying to apply this to other languages, but I just hit some other issues while testing the generated code:

  • java: BrowserContext.routeFromHAR first argument should be a java.nio.Path (api here) but codegen is generating a string, so it fails to compile.
  • python: in pytest, I got the following error because pytest library is not imported:
    @pytest.fixture(scope="session")
NameError: name 'pytest' is not defined
  • csharp: as MSTest, it's generating context.RouteFromHARAsync but it fails to compile, it should be Context.RouteFromHARAsync

Should I open a new bug report or address it in this PR?

This comment has been minimized.

@pavelfeldman
Copy link
Member

Should I open a new bug report or address it in this PR?

I'd fix it here - that's what we would do if we were implementing it anyways.

…-save-har-glob

Bugs detected while testing the generated code were also fixed: see microsoft#34048 (comment)

Fixes: microsoft#34020
Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:575:5 › run-server › should properly disconnect when connection closes from the client side @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37394 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit c2d057b into microsoft:main Dec 18, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Codegen with --save-har-glob should add glob expression into generated code
2 participants