Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Dialog UI for upcoming settings menu #34058

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Dec 17, 2024

The dialog/new UI controls from #34010, separated into its own PR.

This change only touches the settings view in UI Mode, which has been verified to continue functioning as normal.

@agg23 agg23 requested a review from pavelfeldman December 17, 2024 20:52

This comment has been minimized.

This comment has been minimized.

packages/trace-viewer/src/ui/settingsView.css Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/settingsView.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/uiModeView.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/shared/dialog.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/shared/dialog.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/shared/dialog.tsx Outdated Show resolved Hide resolved

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-test-package-managers.spec.ts:54:5 › npm: uninstalling ct removes playwright bin @package-installations-macos-latest
⚠️ [webkit-library] › library/page-event-crash.spec.ts:42:1 › should throw on any action after page crashes @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/page-event-crash.spec.ts:55:1 › should cancel waitForEvent when page crashes @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/selector-generator.spec.ts:197:5 › selector generator › should use internal:has-text @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37389 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 merged commit a8dfdc8 into microsoft:main Dec 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants