Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move protocol to d.ts types only files #34077

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Dec 18, 2024

recorder,html-reporter types were moved already to a d.ts file and protocol (this PR) have some shared types we require in playwright/playwright-core. We renamed them from .ts to .d.ts to be more explicit that these are types only.

Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1
❌ [webkit-page] › page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

3 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18

37392 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 4c9a116 into microsoft:main Dec 18, 2024
27 of 29 checks passed
@mxschmitt mxschmitt deleted the make/protocol-types-only branch December 18, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants