WebDriver BiDi: "browsingContext.captureScreenshot" accepts quality from 0 to 1 #34097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Playwright accepts a range for the
quality
argument from0
to100
, the WebDriver BiDi protocol defines it from0
to1
.This PR fixes it by converting the Playwright range to
[0..1]
. With the patch applied not only 4 tests withinpage-screenshot.spec.ts
are passing but 39.@yury-s can you please take a look?