Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use checkInstalledSoftwareOnDisk for itest #34103

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Dec 19, 2024

This allows us to keep passing Arrays and we don't have to create Set's all the time.

This helps #34078.

This comment has been minimized.

tests/installation/npmTest.ts Outdated Show resolved Hide resolved
@mxschmitt mxschmitt changed the title test: introduce toHaveInstalledSoftwareOnDisk expect matcher test: use checkInstalledSoftwareOnDisk for itest Dec 19, 2024

This comment has been minimized.

@mxschmitt mxschmitt merged commit 61ce37c into microsoft:main Dec 19, 2024
29 checks passed
@mxschmitt mxschmitt deleted the itest-add-expect branch December 19, 2024 21:09
Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-update.spec.ts:83:5 › should pick new / deleted tests @ubuntu-latest-node20-1
⚠️ [playwright-test] › ui-mode-trace.spec.ts:343:5 › should work behind reverse proxy @ubuntu-latest-node22-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:31:3 › should use proxy @smoke @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/selector-generator.spec.ts:321:7 › selector generator › should prioritize attributes correctly › name @webkit-ubuntu-22.04-node18

37390 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants