Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bidi): add csv report #34107

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore(bidi): add csv report #34107

merged 1 commit into from
Dec 20, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Dec 20, 2024

No description provided.

Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node22
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:80:5 › should show console messages for test @macos-latest-node18-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:169:1 › should complain about newer version of trace in old viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37396 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit cc98166 into microsoft:main Dec 20, 2024
29 of 31 checks passed
@yury-s yury-s deleted the bidi-csv-reporter branch December 20, 2024 06:59
row.push(test.expectedStatus);
row.push(test.outcome());
const result = test.results.find(r => r.error);
const errorMessage = stripAnsi(result?.error?.message.replace(/\s+/g, ' ').trim().substring(0, 1024));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yury-s i've used the 1024 cap as an example. Maybe we can make that as well configurable?

Also does it produce a message without all the escape characters for colors? That would be pretty neat.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it looks like I'm not able to specify the csv reporter locally with the --report argument. I assume this is something special for Bidi only. What could I use here to not have to run my own converter on the created json file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally added it in CI branch only in the config, feel free to add it in the other branch too:

['./csvReporter', { outputFile: path.join(outputDir, 'report.csv') }],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make that as well configurable?

Feel free to send PRs adding options you like.

Also does it produce a message without all the escape characters for colors? That would be pretty neat.

Yes, stripAnsi does that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally added it in CI branch only in the config, feel free to add it in the other branch too:

['./csvReporter', { outputFile: path.join(outputDir, 'report.csv') }],

Created PR #34167.

Maybe we can make that as well configurable?

Feel free to send PRs adding options you like.

I'm going to wait until I feel it's necessary to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants