-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bidi): add csv report #34107
chore(bidi): add csv report #34107
Conversation
Test results for "tests 1"7 flaky37396 passed, 650 skipped Merge workflow run. |
row.push(test.expectedStatus); | ||
row.push(test.outcome()); | ||
const result = test.results.find(r => r.error); | ||
const errorMessage = stripAnsi(result?.error?.message.replace(/\s+/g, ' ').trim().substring(0, 1024)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yury-s i've used the 1024 cap as an example. Maybe we can make that as well configurable?
Also does it produce a message without all the escape characters for colors? That would be pretty neat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it looks like I'm not able to specify the csv reporter locally with the --report
argument. I assume this is something special for Bidi only. What could I use here to not have to run my own converter on the created json file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally added it in CI branch only in the config, feel free to add it in the other branch too:
['./csvReporter', { outputFile: path.join(outputDir, 'report.csv') }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can make that as well configurable?
Feel free to send PRs adding options you like.
Also does it produce a message without all the escape characters for colors? That would be pretty neat.
Yes, stripAnsi
does that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally added it in CI branch only in the config, feel free to add it in the other branch too:
['./csvReporter', { outputFile: path.join(outputDir, 'report.csv') }],
Created PR #34167.
Maybe we can make that as well configurable?
Feel free to send PRs adding options you like.
I'm going to wait until I feel it's necessary to add.
No description provided.