chore: Update Testcontainers for .NET #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HofmeisterAn
commented
Oct 12, 2023
| .WithCommand("sh", tempScriptFile) | ||
| .Build(); | ||
| .WithImage(image) | ||
| .WithBindMount(srcDirectoryPath, "/src") |
There was a problem hiding this comment.
It is recommended to utilize the WithResourceMapping API here too. This adjustment will ensure that the implementation works correct with remote Docker hosts. I have not made the changes because I am unsure about the file sizes.
| .WithImage(image) | ||
| .WithBindMount(srcDirectoryPath, "/src") | ||
| .WithResourceMapping(Encoding.Default.GetBytes(input), $"/src/{tempScriptFile}") | ||
| .WithWaitStrategy(Wait.ForUnixContainer().AddCustomWaitStrategy(new ScriptCompleted())) |
There was a problem hiding this comment.
The wait strategy I have implemented assumes that the container's startup process should wait until the shell script has completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hi 👋, I noticed that the project is currently using an outdated version of Testcontainers for .NET. This pull request updates the version to the latest release.
Furthermore, this pull request applies Testcontainers' best practices. It is typically preferred to utilize the
WithResourceMappingAPI to copy files into the container rather than binding them. This is especially crucial when dealing with different Docker environments, as binding a volume can sometimes fail, particularly in remote Docker setups. This also eliminates the need to create the temporary script file on the test host.Furthermore, I have introduced a wait strategy as part of this pull request. Wait strategies are necessary to indicate the readiness of the container (service inside the container) or serving as a status indicator once the container's entry point has completed its execution.
Why is it important?
-
Related issues
-