Skip to content
This repository has been archived by the owner on Mar 29, 2021. It is now read-only.

Updated Url.js to support local images #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mainak30121994
Copy link

Added support for local image files

Added support for local image files
@DongyuZhao
Copy link
Contributor

  1. Please modify the code in src and run gulp, it will generate the code in dist. Any direct modification in dist could lost since gulp will delete this folder before it build and copy new files into it.
    2.Please merge this PR to release_1.x branch as that branch is what we are currently using in production. master branch is a working branch for latest schema.

Copy link
Contributor

@DongyuZhao DongyuZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not modify the file in dist directly. Dist folder is the output folder of the compilation from src and any direct modification will lost once we run build. Please modify files in src and run gulp to make this change.

Copy link
Contributor

@DongyuZhao DongyuZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the new test rule into a separate function for semantic comprehension.

Copy link
Contributor

@DongyuZhao DongyuZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the modification based on release_1.x branch and merge it back to release_1.x since it is currently the production branch. Master branch is a working branch and wont go alive in product in a certain period of time.

@DongyuZhao
Copy link
Contributor

#11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants