[Switch] make sure wasOn is set properly (#1871)

microsoft · Jul 6, 2023 · 28dd130 · 28dd130
1 parent e76df51
commit 28dd130
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/React/Base/RCTUIKit.h b/React/Base/RCTUIKit.h
@@ -546,7 +546,7 @@ typedef UISwitch RCTUISwitch;
 #else
 @interface RCTUISwitch : NSSwitch
 NS_ASSUME_NONNULL_BEGIN
-@property (nonatomic, assign, getter=isOn) BOOL on;
+@property (nonatomic, getter=isOn) BOOL on;
 
 - (void)setOn:(BOOL)on animated:(BOOL)animated;
 

diff --git a/React/Base/macOS/RCTUIKit.m b/React/Base/macOS/RCTUIKit.m
@@ -642,7 +642,7 @@ - (BOOL)isOn
 
 - (void)setOn:(BOOL)on
 {
-	self.state = on ? NSControlStateValueOn : NSControlStateValueOff;
+	[self setOn:on animated:NO];
 }
 
 - (void)setOn:(BOOL)on animated:(BOOL)animated {

diff --git a/React/Views/RCTSwitchManager.m b/React/Views/RCTSwitchManager.m
@@ -46,7 +46,7 @@ - (void)onChange:(RCTSwitch *)sender
     if ([view isKindOfClass:[RCTSwitch class]]) {
       [(RCTSwitch *)view setOn:value animated:NO];
     } else {
-      RCTLogError(@"view type must be UISwitch");
+      RCTLogError(@"view type must be RCTUISwitch"); // [macOS]
     }
   }];
 }