Don't passthru key events that override Pressibilty api's

[shwanton]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

#1623 added support for "Enter" and "Space" as default keys to trigger onKeyDown on Pressability which will call onPress
If the onKeyDown or onKeyUp was passed as a prop to TouchableWithoutFeedback, this would clobber the Pressability callback and the onKeyDown -> onPress chain would never get triggered.

CleanShot.2023-02-10.at.15.33.42.mp4

Pressibility supports calling the onKeyDown|up if it's passed as a prop.

react-native-macos/Libraries/Pressability/Pressability.js

Lines 627 to 630 in b2b61ac

	const {onKeyDown} = this._config;
	if (onKeyDown != null) {
	onKeyDown(event);
	}

Changeling

[macOS] [Fix] - Don't passthru key events that override Pressibilty api's

Test Plan

CleanShot.2023-02-10.at.15.32.51.mp4

[Saadnajmi]

Interesting, I didn't realize PASSTHROUGH_PROPS existed. It kinda feels like we shouldn't pass through any of the props handled by Pressability? Should we remove validKeysUp/Down as well?

[shwanton]

Interesting, I didn't realize PASSTHROUGH_PROPS existed. It kinda feels like we shouldn't pass through any of the props handled by Pressability? Should we remove validKeysUp/Down as well?

If those callbacks are being handled in Pressability, we should remove them from PASSTHROUGH_PROPS to avoid accidental override.

[Saadnajmi]

FWIW, I personally feel like all the Touchable* components are soft deprecated and I don't want to support them. Buuuut way too many people still use it so I can't pitch that to React Native Core just yet 😅.

In the meantime, I would recommend that you replace existing uses of Touchable with Pressable for the best experience :)

[shwanton]

FWIW, I personally feel like all the Touchable* components are soft deprecated and I don't want to support them. Buuuut way too many people still use it so I can't pitch that to React Native Core just yet 😅.

In the meantime, I would recommend that you replace existing uses of Touchable with Pressable for the best experience :)

Yes, completely agree and we are slowly working on replacing them with Touchable in our code base!

[shwanton]

Interesting, I didn't realize PASSTHROUGH_PROPS existed. It kinda feels like we shouldn't pass through any of the props handled by Pressability? Should we remove validKeysUp/Down as well?

Just looked into this. Since validKeysUp/Down can be overridden with props and don't delegate to the underlying property, we shouldn't remove them from PASSTHROUGH_PROPS.