Handle state change in TreatmentView.tsx
#1923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <[email protected]>
gaugup
requested review from
tongyu-microsoft,
romanlutz,
vinuthakaranth,
xuke444,
RubyZ10 and
hawestra
as code owners
| ) { | ||
| if ( | ||
| prevProps.data[0].local_policies.length !== | ||
| this.props.data[0].local_policies.length |
There was a problem hiding this comment.
Could there be a case where length is same but the policies have been updated?
can we use _.isequal(prevprops, currentprops) in that case?
Why is it always comparing with 0th index in prevProps.data[0] and this.props.data[0]? Should it take selectedIndex from state?
romanlutz
reviewed
Jan 24, 2023
| public componentDidUpdate(prevProps: ITreatmentViewProps): void { | ||
| if ( | ||
| prevProps.data && | ||
| this.props.data && |
There was a problem hiding this comment.
Shouldn't this check for the length of data being at least 1, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that causal component can update if the global cohort changes, there was a bug in
TreatmentView.tsxwhere new treatment policy for a new global cohort wouldn't update the Treatment chart. The fix is to check if the number of policy samples are different in the current props and the previous props and update the state if they are unequal.Checklist