Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release file for erroranalysis #2289

Closed
wants to merge 8 commits into from
Closed

Conversation

Advitya17
Copy link
Collaborator

Description

Updated release file with torch-conda support due to vision_explanation_methods dependency with the OD scenario, which contains the Error Labeling work and utilizes torch & torchvision.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@Advitya17 Advitya17 enabled auto-merge (squash) August 29, 2023 00:13
1 similar comment
1 similar comment
.github/workflows/CI-python-vision.yml Outdated Show resolved Hide resolved
.github/workflows/CI-python-vision.yml Outdated Show resolved Hide resolved
packageDirectory:
["erroranalysis", "rai_test_utils"]
operatingSystem: [ubuntu-latest, macos-latest, windows-latest]
pythonVersion: ["3.8", "3.9", "3.10"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erroranalysis supports 3.6 onwards. Are we willing to drop support for them? If so, please update the setup.py file. Not testing and hoping that it works sounds dangerous to me.

@imatiach-msft FYI

.github/workflows/CI-python-vision.yml Outdated Show resolved Hide resolved
- name: Install package
shell: bash -l {0}
run: |
pip install -v -e .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is without the extras (which would be pip install .[object-detection]). What about with extras? I'm a bit confused honestly, because you installed the requirements for the extras above. So this is neither really (?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romanlutz I installed requirements-object-detection.txt under the Install extras name. pip install .[object_detection] would just install this file under the hood; let me know if I should replace directly installing from test file to using the extras term?

1 similar comment
@Advitya17 Advitya17 closed this Dec 4, 2023
@Advitya17 Advitya17 deleted the agemawat/release_ea branch December 4, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants