-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated release file for erroranalysis
#2289
Conversation
…olbox into agemawat/release_ea
1 similar comment
…olbox into agemawat/release_ea
…olbox into agemawat/release_ea
1 similar comment
packageDirectory: | ||
["erroranalysis", "rai_test_utils"] | ||
operatingSystem: [ubuntu-latest, macos-latest, windows-latest] | ||
pythonVersion: ["3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
erroranalysis supports 3.6 onwards. Are we willing to drop support for them? If so, please update the setup.py file. Not testing and hoping that it works sounds dangerous to me.
@imatiach-msft FYI
- name: Install package | ||
shell: bash -l {0} | ||
run: | | ||
pip install -v -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is without the extras (which would be pip install .[object-detection]). What about with extras? I'm a bit confused honestly, because you installed the requirements for the extras above. So this is neither really (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romanlutz I installed requirements-object-detection.txt
under the Install extras name. pip install .[object_detection]
would just install this file under the hood; let me know if I should replace directly installing from test file to using the extras term?
Description
Updated release file with torch-conda support due to
vision_explanation_methods
dependency with the OD scenario, which contains the Error Labeling work and utilizes torch & torchvision.Checklist