Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Scala Connector with Service Principal using MSAL.scala #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ravikd744
Copy link

dependency jars required to be imported in databricks cluster:
spark_mssql_connector_2_11_1_1_0.jar
oauth2_oidc_sdk_7_4.jar
slf4j_api_1_7_28.jar
jackson_databind_2_10_1.jar
lombok_1_18_6.jar
json_smart_2_3.jar
nimbus_jose_jwt_8_14_1.jar
content_type_2_0.jar
asm_5_0_4.jar
accessors_smart_1_2.jar
lang_tag_1_4_4.jar
jcip_annotations_1_0_1.jar
msal4j_1_6_1.jar

dependency jars required to be imported in databricks cluster:
spark_mssql_connector_2_11_1_1_0.jar
oauth2_oidc_sdk_7_4.jar
slf4j_api_1_7_28.jar
jackson_databind_2_10_1.jar
lombok_1_18_6.jar
json_smart_2_3.jar
nimbus_jose_jwt_8_14_1.jar
content_type_2_0.jar
asm_5_0_4.jar
accessors_smart_1_2.jar
lang_tag_1_4_4.jar
jcip_annotations_1_0_1.jar
msal4j_1_6_1.jar
@ghost
Copy link

ghost commented Aug 13, 2020

CLA assistant check
All CLA requirements met.

@shivsood
Copy link
Collaborator

@ravikd744 Thanks for the PR. Can u please add more context to the PR? what's problem the users may face and the where the sample can help. Thanks.

@arvindshmicrosoft @rajmera3 for user samples review.

@ravikd744
Copy link
Author

Hi @shivsood , i couldnt find any reference sample for using MSAL with this connector, particularly the list of jars to be included in the databricks cluster. Hopefully, it helps users to get started with the MSAL integration for the connector with ease.

@rajmera3
Copy link
Contributor

rajmera3 commented Aug 28, 2020

Thanks @ravikd744! Are you able to make a notebook that has your comment of what the dependency jars are as well as this code? Don't want users to lose that information and then get stuck trying to use this sample.

rajmera3
rajmera3 previously approved these changes Aug 28, 2020
@rajmera3 rajmera3 self-requested a review August 28, 2020 16:25
@rajmera3 rajmera3 dismissed their stale review August 28, 2020 16:25

Ask for notebook or code comment of dependency jars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants