Add a timeout for getting suggestions from the LMProvider #18234
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
approved these changes
Nov 22, 2024
DHowett
reviewed
Nov 22, 2024
DHowett
requested changes
Nov 22, 2024
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
lhecker
reviewed
Nov 23, 2024
| @@ -38,6 +38,7 @@ namespace winrt::Microsoft::Terminal::Query::Extension::implementation | |||
| winrt::hstring _AIKey; | |||
| winrt::Windows::Web::Http::HttpClient _httpClient{ nullptr }; | |||
| IBrandingData _brandingData{ winrt::make<OpenAIBranding>() }; | |||
| winrt::Windows::Foundation::IAsyncOperationWithProgress<winrt::Windows::Web::Http::HttpResponseMessage, winrt::Windows::Web::Http::HttpProgress> _lastRequest{ nullptr }; | |||
There was a problem hiding this comment.
You can just make this a local variable that you capture in the cancellationToken lambda. This avoids cancelling the wrong request.
Comment on lines
+157
to
+158
| const auto response{ co_await sendRequestOperation }; | ||
| _lastRequest = sendRequestOperation; |
There was a problem hiding this comment.
I don't think this is effective if you set it after the wait on the request. The .get() below should IMO also be replaced with a _lastRequest = ... and co_await.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a 5-second timeout to get a response from the LMProvider so we don't loop forever in the case of network issues/the service being unavailable
Validation Steps Performed
User receives an error message if we don't get a response within 5 seconds
PR Checklist