Properly run phpstan in ci

microsoft · Oct 8, 2022 · 6060b96 · 6060b96
1 parent a6e2909
commit 6060b96
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -48,4 +48,4 @@ jobs:
         run: bash ci/run_tests_dockerized.sh ${{ matrix.PHP_VERSION }}
 
       - name: Run static analysis (PHP 7.2 only)
-        run: if [[ "$STATIC_ANALYSIS" == true ]]; then bash ci/run_phpstan_dockerized.sh ${{ matrix.PHP_VERSION }}; fi
+        run: if [[ "${{ matrix.STATIC_ANALYSIS }}" == true ]]; then bash ci/run_phpstan_dockerized.sh ${{ matrix.PHP_VERSION }}; fi
diff --git a/ci/run_phpstan.sh b/ci/run_phpstan.sh
@@ -6,6 +6,6 @@ set -xeu
 # This installs and runs phpstan
 # TODO: Remove separate phpstan install step after https://github.com/microsoft/tolerant-php-parser/pull/385 is merged
 if [ ! -d vendor/phpstan/phpstan ]; then
-    composer.phar require --dev phpstan/phpstan@^1.8
+    composer.phar require --dev phpstan/phpstan=^1.8
 fi
 ./vendor/bin/phpstan analyze