Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for vite #172

Merged
merged 2 commits into from
May 5, 2022
Merged

Add a test for vite #172

merged 2 commits into from
May 5, 2022

Conversation

rbuckton
Copy link
Member

This adds a test for vite.

Related to #143

@rbuckton rbuckton requested a review from weswigham February 10, 2022 20:26
@rbuckton rbuckton mentioned this pull request Feb 10, 2022
Open
@rbuckton
Copy link
Member Author

This also drops node@10 from the test matrix since its out of LTS support, and adds node@16 to the test matrix in its place.

@DanielRosenwasser
Copy link
Member

What triggers this running in CI?

@rbuckton
Copy link
Member Author

.github/workflows/CI.yml I would assume

orta
orta approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here

@DanielRosenwasser DanielRosenwasser merged commit 5bfaf87 into main May 5, 2022
@DanielRosenwasser DanielRosenwasser deleted the add-test-vite branch May 5, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@orta orta orta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbuckton @DanielRosenwasser @orta @weswigham