Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cld3] Cleanup, use protobuf config #37495

Merged
merged 1 commit into from
Mar 18, 2024
Merged

[cld3] Cleanup, use protobuf config #37495

merged 1 commit into from
Mar 18, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Mar 16, 2024

By-product of reviewing #35781.

Not upstreaming the changes due to inactivity. google/cld3#85 (comment).

@jimwang118 jimwang118 added the category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. label Mar 18, 2024
@jimwang118
Copy link
Contributor

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Mar 18, 2024
@BillyONeal BillyONeal merged commit a23053f into microsoft:master Mar 18, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the fixes! Thanks for checking up with upstream!

@dg0yt dg0yt deleted the cld3 branch March 19, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @jimwang118 @BillyONeal