-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beman-project-execution26] new port #42185
Open
autoantwort
wants to merge
1
commit into
microsoft:master
Choose a base branch
from
autoantwort:beman-project-execution26
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[beman-project-execution26] new port #42185
autoantwort
wants to merge
1
commit into
microsoft:master
from
autoantwort:beman-project-execution26
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
force-pushed
the
beman-project-execution26
branch
from
November 16, 2024 13:17
90a1673
to
71e9b1d
Compare
WangWeiLin-MV
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Nov 18, 2024
autoantwort
force-pushed
the
beman-project-execution26
branch
from
November 18, 2024 18:59
71e9b1d
to
46939ce
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
|
||
vcpkg_cmake_config_fixup(PACKAGE_NAME beman_execution26 CONFIG_PATH lib/cmake/beman_execution26) | ||
|
||
file(INSTALL "${SOURCE_PATH}/LICENSE.txt" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
file(INSTALL "${SOURCE_PATH}/LICENSE.txt" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) | |
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE.txt") |
dg0yt
reviewed
Nov 22, 2024
vcpkg_cmake_configure( | ||
SOURCE_PATH "${SOURCE_PATH}" | ||
OPTIONS_DEBUG | ||
-DFETCHCONTENT_SOURCE_DIR__PROJECT_OPTIONS="${PROJECT_OPTIONS_SOURCE_PATH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
-DFETCHCONTENT_SOURCE_DIR__PROJECT_OPTIONS="${PROJECT_OPTIONS_SOURCE_PATH}" | |
"-DFETCHCONTENT_SOURCE_DIR__PROJECT_OPTIONS=${PROJECT_OPTIONS_SOURCE_PATH}" | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.