Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openal-soft] Update to 1.24.0 #42196

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpogue
Copy link
Contributor

@dpogue dpogue commented Nov 16, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Nov 18, 2024
@Cheney-W
Copy link
Contributor

The downstream libmikmod is now failing to install due to the following issue:
libmikmod:x64-windows-static
libmikmod:x64-windows-static-md

OpenAL32.lib(wasapi.cpp.obj) : error LNK2019: unresolved external symbol __imp_AvSetMmThreadCharacteristicsW referenced in function "public: int __cdecl `anonymous namespace'::WasapiPlayback::mixerProc(void)" (?mixerProc@WasapiPlayback@?A0x0844112c@@QEAAHXZ)
OpenAL32.lib(wasapi.cpp.obj) : error LNK2019: unresolved external symbol __imp_AvRevertMmThreadCharacteristics referenced in function "public: void __cdecl `anonymous namespace'::AvrtHandleCloser::operator()(void *)" (??RAvrtHandleCloser@?A0x0844112c@@QEAAXPEAX@Z)
mikmod.dll : fatal error LNK1120: 2 unresolved externals

The downstream sfml is now failing to install due to the following issue:
sfml:x64-osx
sfml:arm64-osx

/Users/vcpkg/Data/installed/x64-osx/include/AL/al.h:478:53: error: expected function body after function declarator
AL_API void AL_APIENTRY alEnable(ALenum capability) AL_API_NOEXCEPT;

More logs you could get from https://dev.azure.com/vcpkg/public/_build/results?buildId=109407&view=artifacts&pathAsName=false&type=publishedArtifacts

@dpogue
Copy link
Contributor Author

dpogue commented Nov 18, 2024

Thanks Cheney!

The windows-static ones seem to be due to openal-soft's WASAPI backend now requiring linking against avrt, and that dependency doesn't get communicated properly in static builds. Patching libmikmod would probably fix it, but that doesn't seem like the ideal approach.

I'm not sure what's causing the issues on macOS, since sfml also has code that uses noexcept and that's not causing issues 😕

@dg0yt
Copy link
Contributor

dg0yt commented Nov 18, 2024

The windows-static ones seem to be due to openal-soft's WASAPI backend now requiring linking against avrt, and that dependency doesn't get communicated properly in static builds. Patching libmikmod would probably fix it, but that doesn't seem like the ideal approach.

Add the missing link libs to the installed pc files (openal.pc). Ask if you need more information.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 18, 2024

I'm not sure what's causing the issues on macOS, since sfml also has code that uses noexcept and that's not causing issues 😕

That's why I usually add the command line when reporting errors. Look:

/Library/Developer/CommandLineTools/usr/bin/c++ -DAL_LIBTYPE_STATIC -DFLAC__NO_DLL -DOV_EXCLUDE_STATIC_CALLBACKS -DSFML_STATIC -I/Users/vcpkg/Data/b/sfml/src/2.6.2-8c34997038.clean/include -I/Users/vcpkg/Data/b/sfml/src/2.6.2-8c34997038.clean/src -isystem /Users/vcpkg/Data/b/sfml/src/2.6.2-8c34997038.clean/extlibs/headers/minimp3 -isystem /Users/vcpkg/Data/installed/x64-osx/include -isystem /Users/vcpkg/Data/installed/x64-osx/include/AL -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk -mmacosx-version-min=13.0 -fvisibility=hidden  -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wcast-align -Wunused -Woverloaded-virtual -Wconversion -Wsign-conversion -Wdouble-promotion -Wformat=2 -Wnull-dereference -Wold-style-cast -Wpedantic -Wno-unknown-warning-option -MD -MT src/SFML/Audio/CMakeFiles/sfml-audio.dir/SoundBuffer.cpp.o -MF src/SFML/Audio/CMakeFiles/sfml-audio.dir/SoundBuffer.cpp.o.d -o src/SFML/Audio/CMakeFiles/sfml-audio.dir/SoundBuffer.cpp.o -c /Users/vcpkg/Data/b/sfml/src/2.6.2-8c34997038.clean/src/SFML/Audio/SoundBuffer.cpp

The line lacks the desired C++ standard option. And so you don't even get C++11. And so you don't get noexcept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants