[libavif] Fix usage requirements export #42250
Open
+143
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaLiu0311
added
the
category:port-bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
CI still doesn't start @BillyONeal. |
|
Yeah, something is broken. Having difficulty trying to restore it due to the storm damage last night https://www.seattletimes.com/seattle-news/weather/bomb-cyclone-over-450000-people-without-power-in-western-washington/ |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I destroyed and recreated all the pools and that seems to have fixed it for now, macs will be slow until I wake them all back up since that is a manual process. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
:sigh: One more time |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MonicaLiu0311
approved these changes
Nov 22, 2024
MonicaLiu0311
added
the
info:reviewed
BillyONeal
reviewed
Nov 22, 2024
| + install(EXPORT ${PROJECT_NAME}-config DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME} FILE ${PROJECT_NAME}-targets.cmake) | ||
| + if(NOT BUILD_SHARED_LIBS) | ||
| + target_include_directories(avif_static PUBLIC $<INSTALL_INTERFACE:include>) | ||
| + set(avif_static_link_libs yuv) |
There was a problem hiding this comment.
Stupid question: Why is this yuv rather than yuv::yuv like above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #41569.
Fixes #42112.
Alternative to #42151.