Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg_copy_pdbs] Fix PDB path matching for link.exe on Wine #42265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huangqinjin
Copy link
Contributor

Fixes #42264.

Also fixes the dot escaping.

@BillyONeal BillyONeal changed the title [vcpkg_copy_pdbs] Fix PDB path matching [vcpkg_copy_pdbs] Fix PDB path matching for link.exe on Wine Nov 20, 2024
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me if build passes

@BillyONeal
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Nov 21, 2024
@BillyONeal
Copy link
Member

The build failures so far look like baseline issues, will keep you posted.

@BillyONeal
Copy link
Member

The build failures are all openimageio which exactly matches the previous CI build, so I will merge through them: https://dev.azure.com/vcpkg/public/_build/results?buildId=109536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcpkg_copy_pdbs() no longer works on non-Windows after #41609
3 participants