[cppgraphqlgen] Expose clientgen/schemagen features #42267
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling both of these allows building a version of the library which does not depend on boost, which can be nice for production deployments. The default behaviour is unchanged.
|
@microsoft-github-policy-service agree |
WangWeiLin-MV
added
the
category:port-feature
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
reviewed
Nov 22, 2024
Comment on lines
+20
to
+22
| "clientgen", | ||
| "rapidjson", | ||
| "schemagen" |
There was a problem hiding this comment.
This appears to break https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#default-features-should-enable-behaviors-not-apis . Can these be made not default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling both of these allows building a version of the library which does not depend on boost. The clientgen/schemagen CLI tools are generally only required in development environments and CI. Thus it may be preferable to link against a boostless cppgraphqlgen when building for release.
Default behaviour for vcpkg users who do not disable default-features when installing cppgraphqlgen remains unchanged.
The flags in question can be found here - https://github.com/microsoft/cppgraphqlgen/blob/681b0e1942521d4dd7806a4badfce9aa703f6dcf/CMakeLists.txt#L37. In testing this works as expected when building both with and without the default feature list. However, I am not very familiar with CMake et al, so please let me know if there are any issues with my implementation.
./vcpkg x-add-version --alland committing the result.