Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kerbal] update to v2024.11.1 #42307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[kerbal] update to v2024.11.1 #42307

wants to merge 1 commit into from
+10 −5

Conversation

WentsingNee
Copy link
Contributor

@WentsingNee WentsingNee commented Nov 22, 2024 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 22, 2024
jimwang118
jimwang118 requested changes Nov 22, 2024
View reviewed changes
ports/kerbal/vcpkg.json Outdated Show resolved Hide resolved
jimwang118
jimwang118 previously approved these changes Nov 22, 2024
View reviewed changes
@WentsingNee
Copy link
Contributor Author

@jimwang118 should I squash the second commit into the first one?

@jimwang118
Copy link
Contributor

@jimwang118 should I squash the second commit into the first one?

You need to run the command: ./vcpkg x-add-version {portname} --overwrite-version, and then submit the regenerated kerbal.json file.

@WentsingNee
Copy link
Contributor Author

@jimwang118 should I squash the second commit into the first one?

You need to run the command: ./vcpkg x-add-version {portname} --overwrite-version, and then submit the regenerated kerbal.json file.

done

BillyONeal
BillyONeal reviewed Nov 22, 2024
View reviewed changes
ports/kerbal/vcpkg.json
"description": "Kerbal C++ Template Library",
"homepage": "https://github.com/WentsingNee/Kerbal",
"license": "LGPL-3.0",
"license": "LGPL-3.0-or-later",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain where the -or-later is documented? The LICENSE does not say that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this change is suggested by @jimwang118 during his review. Actually, I didn't change my project's LICENSE these days.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#42307 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't focus and track the policy published by the vcpkg official so I also don't understand. Whether you have updated the policy related to the LICENSE in pursuit of the compatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@jimwang118 jimwang118 jimwang118 left review comments

Assignees

@jimwang118 jimwang118

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WentsingNee @jimwang118 @BillyONeal