Add license information for a set of ports #42312
Conversation
aristotelos
force-pushed
the
add-missing-licenses
branch
2 times, most recently
from
8ed6c02
to
9915ff5
Compare
See:
- https://github.com/google/double-conversion/blob/master/LICENSE
- http://glew.sourceforge.net/mesa.txt
- https://github.com/jasper-software/jasper/blob/master/LICENSE.txt
- https://github.com/BLAKE2/libb2/blob/master/COPYING
- https://github.com/microsoft/vcpkg/blob/master/ports/libiconv/portfile.cmake#L56
- https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/libmount/COPYING
- https://gitlab.freedesktop.org/xorg/lib/libxext/-/blob/master/COPYING
- https://gitlab.freedesktop.org/xorg/lib/libxfixes/-/blob/master/COPYING
- https://gitlab.freedesktop.org/xorg/lib/libxi/-/blob/master/COPYING
- https://gitlab.freedesktop.org/xorg/lib/libxtst/-/blob/master/COPYING
- https://gitlab.freedesktop.org/xorg/lib/libxv/-/blob/master/COPYING
- https://github.com/google/snappy/blob/main/COPYING
- https://gitlab.freedesktop.org/xorg/util/macros/-/blob/master/COPYING
- https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/blob/master/COPYING
aristotelos
force-pushed
the
add-missing-licenses
branch
from
9915ff5
to
9d55fb5
Compare
WangWeiLin-MV
added
the
category:code-cleanup
There was a problem hiding this comment.
The ones that are explicitly null need justification as to why null is incorrect beyond a link to a COPYING file, particularly to COPYING files that are not the license you indicated.
Please:
- Fix the licenses to match what they actually say, and/or
- Supply more concrete justification that refutes what was said in the PRs that added
"license": null, and/or - Remove the edits to ports where you can't do that
and un-draft this PR to request a re-review.
Thanks for your contribution to vcpkg!
| "description": "The OpenGL Extension Wrangler Library (GLEW) is a cross-platform open-source C/C++ extension loading library.", | ||
| "homepage": "https://github.com/nigels-com/glew", | ||
| "license": "MIT AND BSD-3-Clause", |
There was a problem hiding this comment.
This is not supported by the http://glew.sourceforge.net/mesa.txt in the description of the PR, but is supported by https://github.com/nigels-com/glew#copyright-and-licensing , so no change requested.
| "license": null | ||
| "license": "LGPL-2.1-only" |
There was a problem hiding this comment.
This change is wrong, as portfile.cmake explains. (I'm not sure why you linked to this in the PR description despite it contradicting this) null is correct as some parts of the installed port content are not LGPL-2.1-only, and an explanation is necessary to determine which parts are.
There was a problem hiding this comment.
I thought the libiconv port would not distribute iconv itself, I thought it would only distribute the library. But apparently I am mistaken...
| "description": "Xlib-based library for common extensions to the X11 protocol", | ||
| "homepage": "https://gitlab.freedesktop.org/xorg/lib/libxext", | ||
| "license": null, | ||
| "license": "MIT", |
There was a problem hiding this comment.
Your own reference link contradicts this; it does not point at the MIT license. I believe MIT-open-group might be correct.
There was a problem hiding this comment.
Oops, I think indeed this is a complex list of licenses starting wth MIT-open-group but followed by many others...
| "license": null, | ||
| "license": "MIT", |
There was a problem hiding this comment.
As per your own link, I believe 'MIT' is wrong. I know at the top it says 'is licensed under the MIT license', but the actual license text is not the MIT license. In particular this part is closer to the BSD licenses that forbid use of names: https://gitlab.freedesktop.org/xorg/lib/libxi/-/blob/master/COPYING#L23-L41
I think this should remain null.
There was a problem hiding this comment.
Hmm, it should indeed be more specific. When I paste the various licenses in https://tools.spdx.org/app/check_license/, I get:
- MIT-open-group
- SMLNJ
- MIT-open-group
- MIT
So it should probably be MIT-open-group AND SMLNJ AND MIT
| "license": null, | ||
| "license": "X11", |
There was a problem hiding this comment.
The https://gitlab.freedesktop.org/xorg/lib/libxtst/-/blob/master/COPYING#L101-L104 part is not the X11 license. I believe null is correct.
| "license": null, | ||
| "license": "MIT", |
There was a problem hiding this comment.
https://gitlab.freedesktop.org/xorg/lib/libxv/-/blob/master/COPYING is not the MIT license. I believe null is correct.
| "license": null, | ||
| "license": "BSD-3-Clause", |
There was a problem hiding this comment.
I think this one is OK. https://github.com/google/snappy/blob/32ded457c0b1fe78ceb8397632c416568d6714a0/COPYING#L32C1-L32C65 is here and says testdata is licensed differently, but the port does not install the testdata.
| "homepage": "https://gitlab.freedesktop.org/xorg/lib/libxtrans", | ||
| "license": null, | ||
| "license": "MIT-open-group", |
There was a problem hiding this comment.
This is not MIT-open-group: https://gitlab.freedesktop.org/xorg/lib/libxtrans/-/blob/master/COPYING#L103-L121
I believe null is correct.
| "license": null, | ||
| "license": "LGPL-2.1-or-later", |
There was a problem hiding this comment.
I don't think https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/libmount/COPYING is sufficient to prove this, https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/README.licensing as the port references explicitly says that the COPYING part only applies to files without their own license inside. #35738 was justified in setting this to null. Or did you actually check every source file?
|
For now, I am going to abandon this PR, as I am not entirely sure about how the license texts should be matched against a template. @BillyONeal Thanks for the thorough review, and sorry for my lack of confidence to continue. |
See:
Tasks:
./vcpkg x-add-version --alland committing the result.