Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FxCop scripts #18

Open
wants to merge 1 commit into
base: dev15
Choose a base branch
from
Open

Add FxCop scripts #18

wants to merge 1 commit into from

Conversation

benmcmorran
Copy link
Member

Two globalization rules are currently violated.

  1. CultureInfo.CurrentCulture is not always specified when formatting strings. This change appears to be low-priority, does not impact behavior, and may make the code noisier.
  2. In two cases, strings are converted to lowercase. In both instances, the strings are only used for output (test case results and a string summary of command line arguments), so we shouldn't run into issues with normalization. The FxCop file includes exclusions for both cases.

@benmcmorran benmcmorran requested a review from a team September 15, 2017 22:20
Copy link

@LukaszMendakiewicz LukaszMendakiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I guess this should now be squashed before merging.

@LukaszMendakiewicz
Copy link

Since this project switched to consuming NuGet through PackageReference for most of the packages (ideally should be for all, once we iron out some wrinkles around MicroBuild), does Flatten-NuGetPackages even make sense here, and don't the packages referenced through PackageReference pose any problems during analysis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants