Add Service Connector #2511
Add Service Connector #2511
Conversation
If it's not too much work, it would be great to just split those out into a new PR. We will be able to merge that sooner than the service connector changes. |
Will do! |
src/commands/registerCommands.ts
Outdated
| @@ -56,9 +59,13 @@ export function registerCommands(): void { | |||
| registerCommandWithTreeNodeUnwrapping('appService.appSettings.ToggleSlotSetting', toggleSlotSetting); | |||
| registerCommandWithTreeNodeUnwrapping('appService.appSettings.Upload', uploadAppSettings); | |||
| registerCommandWithTreeNodeUnwrapping('appService.Browse', browseWebsite); | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
| //@ts-ignore | |||
There was a problem hiding this comment.
Why are these @ts-ignore's needed? What was the error?
There was a problem hiding this comment.
Pretty sure it's related to this microsoft/vscode-azuretools#1492
There was a problem hiding this comment.
Ah. Let's get microsoft/vscode-azuretools#1492 fixed instead.
There was a problem hiding this comment.
Yup! Once this PR (#2512) is merged I'll pull in the changes so the utils stuff is separate also.
|
Looks good to go, just need to release the package |
|
The previous commit includes hooking up the UI and some changes made in the tools package to make the UI work correctly. I am not totally sure if this is the best approach so any feedback would be great. |
| item ??= await pickWebApp(context); | ||
| if (item instanceof SiteTreeItem) { | ||
| item = <ServiceConnectorGroupTreeItem>item.parent; |
There was a problem hiding this comment.
This seems backwards to me.
If it was a SiteTreeItem, would its parent be the subscription node?
But the ServiceConnectorGroupTreeItem's parent would be the SiteTreeItem, right?
There was a problem hiding this comment.
That is true it wasn't causing any problems for some reason since the type of item when using the command palette was not a SiteTreeItem so it was never calling that line.
I'll flip it but with that implementation I don't thing resourceId will be needed anymore.
There was a problem hiding this comment.
Yeah, I believe that you're right. I know I just approved it, but we could probably disregard the resourceId added in this PR
package.nls.json
Outdated
| @@ -62,6 +64,7 @@ | |||
| "appService.showSavePrompt": "Show warning dialog on remote file uploading.", | |||
| "appService.startStreamingLogs": "Start Streaming Logs", | |||
| "appService.toggleAppSettingVisibility": "Toggle App Value Visibility", | |||
| "appService.validateServiceConnector": "Validate Service Connector...", | |||
There was a problem hiding this comment.
Since there are no additional prompts, the ellipses should be removed.
| const activityContext = { | ||
| ...context, | ||
| ...await createActivityContext(), | ||
| activityTitle: localize('validate', `Validate {0}`, serviceConnectorName), |
There was a problem hiding this comment.
Last thing I promise
| activityTitle: localize('validate', `Validate {0}`, serviceConnectorName), | |
| activityTitle: localize('validate', `Validate connection "{0}"`, serviceConnectorName), |
Related to microsoft/vscode-azuretools#1419
Also includes a utils update (needed for Service Connector) and some changes to fix errors that came with the update.