Add support for domain name label scopes #2703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice into mwf/icy-amber
MicroFish91
commented
Feb 5, 2025
| "@azure/arm-resources": "^5.0.0", | ||
| "@azure/core-client": "^1.7.3", | ||
| "@azure/core-rest-pipeline": "^1.11.0", | ||
| "@microsoft/vscode-azext-azureappservice": "^3.1.0", | ||
| "@microsoft/vscode-azext-azureappservice": "file:../vscode-azuretools/appservice/microsoft-vscode-azext-azureappservice-3.3.1.tgz", |
There was a problem hiding this comment.
I'll clean up the package.json and package-lock.json after these packages are ready to be imported through npm registry.
| uiUtils.listAllIterator(client.webApps.list()).then((sites) => { | ||
| for (const site of sites) { | ||
| const siteName: string = nonNullProp(site, 'name'); |
There was a problem hiding this comment.
Adds a lookahead that checks for duplicate site names and adds a location description in order to help differentiate them, example:
MicroFish91
commented
Feb 5, 2025
| export class WebAppWithDomainLabelScopeCreateStep extends AzureWizardExecuteStep<IWebAppWizardContext> { | ||
| public priority: number = 140; | ||
|
|
||
| public async execute(context: IWebAppWizardContext, progress: Progress<{ message?: string; increment?: number }>): Promise<void> { |
There was a problem hiding this comment.
Most of this file is a straight carryover of the WebAppCreateStep file, but I had to make a call manually without the SDK which means I added a GenericClient call to the API endpoint, and I had to slightly amend the site payload shape because it's different than when updating using the SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the work for supporting the new domain label scopes, see here for more context.
Demos:
Basic_Create
Advanced_Create
Here are the corresponding step changes in the appservice package:
microsoft/vscode-azuretools#1882