Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Durable Task Scheduler resource type #1014

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

philliphoff
Copy link
Member

Adds a resource type for the new Durable Task Scheduler resource.

Signed-off-by: Phillip Hoff <[email protected]>
@philliphoff philliphoff requested a review from a team as a code owner January 10, 2025 06:26
@alexweininger
Copy link
Member

Is this in preparation for changes to the Functions extension?

@philliphoff
Copy link
Member Author

Yes, it'd be to allow the Functions extension to extend DTS resources shown in the Azure tree (which currently show up in the "Unknown" group). I assume it's still the case that we can't add support without this first step?

@alexweininger
Copy link
Member

I assume it's still the case that we can't add support without this first step?

Yes, that's still the case. Just depends on if you'd like us to merge this now, or when the support in Azure Functions is ready.

@philliphoff
Copy link
Member Author

Yes, that's still the case. Just depends on if you'd like us to merge this now, or when the support in Azure Functions is ready.

@alexweininger Is there a reasonable way that I can develop/test the Functions extension support without having this committed first? I seem to vaguely recall a way that I can run multiple in-development extensions together in the same test instance, but it's been a long minute.

@alexweininger
Copy link
Member

Is there a reasonable way that I can develop/test the Functions extension support without having this committed first? I seem to vaguely recall a way that I can run multiple in-development extensions together in the same test instance, but it's been a long minute.

Two ways.

First is to package Azure Resources into a vsix and install it then debug Functions.

Second is to use this Launch config which launches both Azure Resources and Azure Functions. But you'll only be able to set breakpoints in the currently opened extension (in this case Functions) https://github.com/microsoft/vscode-azurefunctions/blob/fe58f7faca18e3e52e4bef833db2a9d068dd3746/.vscode/launch.json#L22-L39

@philliphoff
Copy link
Member Author

philliphoff commented Jan 14, 2025

Second is to use this Launch config which launches both Azure Resources and Azure Functions. But you'll only be able to set breakpoints in the currently opened extension (in this case Functions) https://github.com/microsoft/vscode-azurefunctions/blob/fe58f7faca18e3e52e4bef833db2a9d068dd3746/.vscode/launch.json#L22-L39

@alexweininger That's super useful, thanks; I've used that method to prepare proposed changes to the Functions extension. I've switched this to a draft PR for now; I'll switch it back when we're ready for both to go in.

@philliphoff philliphoff marked this pull request as ready for review January 21, 2025 17:30
@philliphoff
Copy link
Member Author

@alexweininger We're ready for the Functions extensions changes to go it, so it'd be great to get this committed whenever convenient.

@alexweininger
Copy link
Member

alexweininger commented Jan 21, 2025

@philliphoff We're releasing tomorrow, do you want these changes included?

@philliphoff
Copy link
Member Author

@alexweininger If possible, that'd be great. If not, when's the next window?

@alexweininger alexweininger merged commit 40d5e95 into microsoft:main Jan 22, 2025
3 checks passed
@alexweininger
Copy link
Member

@philliphoff I can get it in today

@philliphoff philliphoff deleted the philliphoff-dts-resources branch January 22, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants