Setup for 'vscode-azurearcenabledmachines' extension #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andyleejordan/vscode-arcenabledservers
branch
from
3ba425c to
e57e8ea
Compare
andyleejordan
force-pushed
the
andyleejordan/vscode-arcenabledservers
branch
2 times, most recently
from
13fa13b to
f0e7f28
Compare
andyleejordan
changed the title
andyleejordan
force-pushed
the
andyleejordan/vscode-arcenabledservers
branch
from
f0e7f28 to
2892e39
Compare
andyleejordan
changed the title
|
The implementing repository: https://github.com/microsoft/vscode-azurearcenabledmachines |
|
Everything looks good. I will merge closer to when the extension is releasing (next week tentatively). |
alexweininger
approved these changes
Jan 26, 2024
| @@ -89,6 +89,7 @@ const azExtDisplayInfo: Partial<Record<AzExtResourceType, AzExtResourceTypeDispl | |||
| AppServiceKubernetesEnvironment: { displayName: localize('containerService', 'App Service Kubernetes Environment') }, | |||
| AppServicePlans: { displayName: localize('serverFarms', 'App Service plans') }, | |||
| AppServices: { displayName: localize('webApp', 'App Services') }, | |||
| ArcEnabledMachines: { displayName: localize('arcEnabledMachines', 'Azure Arc-enabled machines') }, | |||
There was a problem hiding this comment.
@andyleejordan would it be okay to remove the Azure part from the display name? We are trying to be consistent about naming. #806
This isn't a release blocker at all.
There was a problem hiding this comment.
I asked about that and was told that "Arc is always prefaced by Azure because the trademark is the combo of the two words."
Now with a fresh marketing-approved name!
andyleejordan
force-pushed
the
andyleejordan/vscode-arcenabledservers
branch
from
2892e39 to
a78c50d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the extension is ready for publishing, this should do it (testing against this locally and figured I'd just draft PR it for awareness).