-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shortcut to switching to sovereign cloud within the tenant view #926
Conversation
Can you put a screenshot of the quick pick please |
Yup I'll edit the description to add that |
just some quick feedback: Maybe we can put (Default) in the description of the "Azure" normal option? |
Yup I'll do that! |
Also I think we'll merge this after we merge the tenant view PR. There might be other small features like this on top of the tenant view that we want to add. |
Sounds good I'll change the branch to main before we merge this. |
{ label: 'Azure (Default)', data: '' }, | ||
{ label: 'Azure China', data: 'ChinaCloud' }, | ||
{ label: 'Azure US Government', data: 'USGovernment' }, | ||
{ label: 'A custom Microsoft Sovereign Cloud', data: 'custom' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they pick custom, should we take them to the setting page so they can actually configure it? We can make this change later though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah we should change the custom since it will cause an error at the moment
This allows users to quickly change their sovereign cloud setting without having to go into the user settings.
The shortcut lives here under the gear icon:
There is also a command palette command titiled:
Azure: Configure Sovereign Cloud
This brings up the below quick pick. The names correspond with the names on the setting. When an item is selected the setting
microsoft-sovereign-cloud.environment
is changed to the corresponding value.(I included the generic azure one so user could switch back easily)
I tested this by switching between an Azure China account and a default Azure account and had no issues.