Read-only Implementation of Managed Identities #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
reviewed
Dec 4, 2024
…osoft/vscode-azureresourcegroups into nat/managedIdentityReadOnly
…osoft/vscode-azureresourcegroups into nat/managedIdentityReadOnly
…osoft/vscode-azureresourcegroups into nat/managedIdentityReadOnly
alexweininger
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
What changed with the icon?
There was a problem hiding this comment.
I am honestly not entirely sure. I think at one point, I changed the name but I ended up reverting that. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Updated description.
The point of this feature is only to list the managed identities and their relationships with source and target resources. The main reason we want to add this is because other extensions such as Functions and Container Apps will be creating managed identity resources for users, but there wouldn't be a way to see them in the tree without this view.
Definitely plan to expand on the feature set, but having the relationship being shown in a tree view is complicated enough as it is, so it's something that we would want to slowly iterate on with team/customer feedback.
There is a bug right now-- because the scope id I'm using to determine the app type is just an Azure id string, it can't tell the difference between app service and functions.
I could do something like retrieving that resource when we see a
Microsoft.siteprovider, but that kind of seems like overkill at this point.Old screenshot:
New screenshot:
