Add Tenant view telemetry and sign in button on tenant view #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can merge, but I think the button icon needs discussion. I don't think that icon is clear, I might prefer using no icon and just using text that says "Add Account". |
package.json
Outdated
| @@ -105,6 +105,12 @@ | |||
| "title": "%azureResourceGroups.logIn%", | |||
| "category": "Azure" | |||
| }, | |||
| { | |||
| "command": "azureResourceGroups.logInButton", | |||
There was a problem hiding this comment.
Should we prefix this command like: azureTenantsView.logInButton?
| } else { | ||
| const subscriptionProvider = await getAzureSubscriptionProvider(this); | ||
| const children: ResourceGroupsItem[] = await OnGetChildrenBase(subscriptionProvider); | ||
| return await callWithTelemetryAndErrorHandling('tenantResourceTreeDataProvider.onGetChildren', async (context: IActionContext) => { |
There was a problem hiding this comment.
Nathan might have input here, but do we want to expose our implementation details in telemetry?
A better name might be azureTenantsView.getChildren?
| @@ -56,8 +56,10 @@ async function updateTenantsSetting(_context: IActionContext, tenants: vscode.Tr | |||
|
|
|||
| for (const [tenantTreeItem, state] of tenants.items) { | |||
| if (state === vscode.TreeItemCheckboxState.Unchecked) { | |||
| _context.telemetry.properties.uncheckedTenant = 'true'; | |||
There was a problem hiding this comment.
We use this now so remove the underscore.
Suggested change
| _context.telemetry.properties.uncheckedTenant = 'true'; | |
| context.telemetry.properties.uncheckedTenant = 'true'; |
package.json
Outdated
| @@ -106,10 +106,10 @@ | |||
| "category": "Azure" | |||
| }, | |||
| { | |||
| "command": "azureResourceGroups.logInButton", | |||
| "title": "%azureResourceGroups.logInButton%", | |||
| "command": "azureTenantsView.logInButton", | |||
There was a problem hiding this comment.
Should the title now be "addAccount"?
alexweininger
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is how the button looks:
